[PATCH v2] vga_switcheroo: Fix impossible judgment condition
Dan Carpenter
dan.carpenter at linaro.org
Thu Oct 26 09:30:22 UTC 2023
On Thu, Oct 26, 2023 at 05:18:04PM +0800, Su Hui wrote:
> 'id' is enum type like unsigned int, so it will never be less than zero.
> It's better to check VGA_SWITCHEROO_UNKNOWN_ID too.
>
> Fixes: 4aaf448fa975 ("vga_switcheroo: set audio client id according to bound GPU id")
> Signed-off-by: Su Hui <suhui at nfschina.com>
> ---
> v2:
> - add check of VGA_SWITCHEROO_UNKNOWN_ID(Dan's suggestion).
>
> By the way, all functions of 'get_client_id' will never return error code
> or VGA_SWITCHEROO_UNKNOWN_ID,should we remove this check or keep it for
> future.
>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter at linaro.org>
regards,
dan carpenter
More information about the dri-devel
mailing list