(subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

Helen Koike helen.koike at collabora.com
Fri Oct 27 17:33:10 UTC 2023



On 26/10/2023 12:31, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Oct 26, 2023 at 11:27:18AM -0300, Helen Koike wrote:
>> On 26/10/2023 10:27, Maxime Ripard wrote:
>>> On Thu, Oct 26, 2023 at 09:08:03AM -0300, Helen Koike wrote:
>>>>
>>>>
>>>> On 26/10/2023 09:01, Helen Koike wrote:
>>>>>
>>>>>
>>>>> On 26/10/2023 07:58, Maxime Ripard wrote:
>>>>>> On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote:
>>>>>>> Flaky tests can be very difficult to reproduce after the facts, which
>>>>>>> will make it even harder to ever fix.
>>>>>>>
>>>>>>> Let's document the metadata we agreed on to provide more context to
>>>>>>> anyone trying to address these fixes.
>>>>>>>
>>>>>>>
>>>>>>> [...]
>>>>>>
>>>>>> Applied to drm/drm-misc (drm-misc-next).
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Could you also apply https://patchwork.kernel.org/project/dri-devel/cover/20231024004525.169002-1-helen.koike@collabora.com/
>>>>> (and the dependencies listed on it).
>>>>
>>>> For some reason, commit message 7/10 (drm/ci: increase i915 job timeout to
>>>> 1h30m) looks incomplete in patchwork, but it looks fine in my branch:
>>>>
>>>> https://gitlab.freedesktop.org/helen.fornazier/linux/-/commits/for-drm-misc-wip/
>>>>
>>>> Let me know if you prefer that I send it again or if you could pull from the
>>>> branch.
>>>
>>> It was fine on lore.kernel.org and that's where I'm pulling from, so it all worked out :)
>>>
>>> Everything you asked for should be applied now
>>>
>>> Maxime
>>
>> Awesome, thank you!
>>
>> Sorry, just another request, could you please pull this other one updating
>> MAINTAINERS?
>>
>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230919182249.153499-1-helen.koike@collabora.com/
> 
> I don't mind, but the expectation (the one I had at least) was that you would do it :)
> 
> If you don't have drm-misc access, please create an account, you have
> done way more than expected to get one already

Nice! I just created this request 
https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/983

Would you mind approving it?

Thanks!
Helen

> 
> Maxime


More information about the dri-devel mailing list