[PATCH 3/8] accel/ivpu: Stop job_done_thread on suspend

Jeffrey Hugo quic_jhugo at quicinc.com
Mon Oct 30 15:03:09 UTC 2023


On 10/28/2023 9:59 AM, Stanislaw Gruszka wrote:
> Stop job_done thread when going to suspend. Use kthread_park() instead
> of kthread_stop() to avoid memory allocation and potential failure
> on resume.
> 
> Use separate function as thread wake up condition. Use spin lock to assure
> rx_msg_list is properly protected against concurrent access.

This tells me what you are doing (and the changes seems to make sense), 
but doesn't say "why".  A quick, one-sentence justification would fix 
this I think.

> Reviewed-by: Karol Wachowski <karol.wachowski at linux.intel.com>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo at quicinc.com>


More information about the dri-devel mailing list