[PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Geert Uytterhoeven geert at linux-m68k.org
Tue Oct 31 09:56:14 UTC 2023


Hi Javier,

On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas
<javierm at redhat.com> wrote:
> Jocelyn Falempe <jfalempe at redhat.com> writes:
> > On 21/10/2023 00:52, Javier Martinez Canillas wrote:
> >> Avoid a possible uninitialized use of the crtc_state variable in function
> >> ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn:
> >>
> >>      drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check()
> >>      error: uninitialized symbol 'crtc_state'.
> >
> > That looks trivial, so you can add:
> >
> > Acked-by: Jocelyn Falempe <jfalempe at redhat.com>
> >
>
> Pushed to drm-misc (drm-misc-next). Thanks!

Looks like you introduced an unintended

    (cherry picked from commit 9e4db199e66d427c50458f4d72734cc4f0b92948)

?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the dri-devel mailing list