[PATCH] drm/amd/display: remove redundant check
José Pekkarinen
jose.pekkarinen at foxhound.fi
Tue Oct 31 11:42:17 UTC 2023
On 2023-10-31 07:48, Greg KH wrote:
> On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
>> This patch addresses the following warning spotted by
>> using coccinelle where the case checked does the same
>> than the else case.
>>
>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
>> WARNING: possible condition with no effect (if == else)
>>
>> Fixes: 974ce181 ("drm/amd/display: Add check for PState change in
>> DCN32")
>>
>> Cc: stable at vger.kernel.org
>
> Why is this relevant for stable?
Hi,
I was asked to send it for stable because this code
looks different in amd-staging-drm-next, see here.
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c#L4661
Feel free to let me know if this is wrong, or if I
need to review some other guidelines I may have missed.
Thanks!
José.
More information about the dri-devel
mailing list