[PATCH 2/2] drm/panel: Add AUO G156HAN04.0 LVDS display support

[Jessica Zhang]

Hi Elmar,

Just had a few minor comments:

Looking at past panel-simple changes, I think the prefix here should be 
"drm/panel: simple:"

On 8/28/2023 2:49 AM, Elmar Albert wrote:
> From: Elmar Albert <ealbert at data-modul.com>
> 
> G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of
> a TFT LCD panel, a driver circuit, and LED backlight system. The screen
> format is intended to supportthe 16:9 FHD, 1920(H) x 1080(V) screen

nit: "support the"

> and 16.7M colors (RGB 8-bits ) with LED backlight driving circuit.
> All input signals are LVDS interface compatible.
> 
> G156HAN04.0 is designed for a display unit of notebook style
> personal computer and industrial machine.
> 
> Signed-off-by: Elmar Albert <ealbert at data-modul.com>
> ---
> Cc: Conor Dooley <conor+dt at kernel.org>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: David Airlie <airlied at gmail.com>
> Cc: devicetree at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 36 ++++++++++++++++++++++++++++
>   1 file changed, 36 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 52572fde9705..4fe6dafcabf6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1050,6 +1050,39 @@ static const struct panel_desc auo_g133han01 = {
>   	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   
> +static const struct display_timing auo_g156han04_timings = {
> +	.pixelclock = { 137000000, 141000000, 146000000 },
> +
> +	.hactive = { 1920, 1920, 1920 },
> +	.hfront_porch = { 60, 60, 60 },
> +	.hback_porch =  { 90, 92, 111 },
> +	.hsync_len =    { 32, 32, 32 },
> +
> +	.vactive = { 1080, 1080, 1080 },
> +	.vfront_porch = { 12, 12, 12 },
> +	.vback_porch =  { 24, 36, 56 },
> +	.vsync_len =    {  8,  8,  8 },
> +};
> +
> +static const struct panel_desc auo_g156han04 = {
> +	.timings = &auo_g156han04_timings,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 344,
> +		.height = 194,
> +	},
> +	.delay = {
> +		.prepare = 50,		/* T2 */
> +		.enable = 200,		/* T3 */
> +		.disable = 110,		/* T10 */
> +		.unprepare = 1000,	/* T13 */

The inclusion of the comments seems unnecessary.

Thanks,

Jessica Zhang

> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>   static const struct drm_display_mode auo_g156xtn01_mode = {
>   	.clock = 76000,
>   	.hdisplay = 1366,
> @@ -4118,6 +4151,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "auo,g133han01",
>   		.data = &auo_g133han01,
> +	}, {
> +		.compatible = "auo,g156han04",
> +		.data = &auo_g156han04,
>   	}, {
>   		.compatible = "auo,g156xtn01",
>   		.data = &auo_g156xtn01,
> -- 
> 2.34.1
>