[RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Mon Sep 11 09:41:12 UTC 2023
On 11/09/2023 11:02, John Watts wrote:
> This is a small 3.5" 640x480 IPS LCD panel.
>
> Signed-off-by: John Watts <contact at jookia.org>
> ---
Thank you for your patch. There is something to discuss/improve.
> +maintainers:
> + - John Watts <contact at jookia.org>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: fascontek,fs035vg158
> +
> + backlight: true
> + port: true
> + power-supply: true
> + reg: true
> + reset-gpios: true
Why do you need all these 5? They are allowed by panel-common.
> +
> + spi-3wire: true
> +
> +required:
> + - compatible
Missing reg. Probably also port.
> + - power-supply
> + - reset-gpios
> +
Best regards,
Krzysztof
More information about the dri-devel
mailing list