[PATCH] staging: fbtft: Removed unnecessary parenthesis around conditions to comply with the checkpatch coding style.
Bagas Sanjaya
bagasdotme at gmail.com
Wed Sep 13 01:32:20 UTC 2023
On Wed, Sep 13, 2023 at 11:02:13AM +1000, Angus Gardner wrote:
> ---
> drivers/staging/fbtft/fb_ra8875.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
No patch description and SoB, so Greg can't take this as-is.
> - if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) {
> + if (par->info->var.xres == 320 && par->info->var.yres == 240) {
Greg prefers explicit parentheses on complex expressions (see [1] and [2]
for examples), hence NAK.
Thanks.
[1]: https://lore.kernel.org/linux-staging/ZCWGOZqdH1kWtOEq@kroah.com/
[2]: https://lore.kernel.org/linux-staging/Y%2FiaYtKk4VSokAFz@kroah.com/
--
An old man doll... just what I always wanted! - Clara
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230913/14bf3ccb/attachment.sig>
More information about the dri-devel
mailing list