[PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks
Thomas Zimmermann
tzimmermann at suse.de
Thu Sep 21 08:55:04 UTC 2023
Hi
Am 21.09.23 um 10:46 schrieb Geert Uytterhoeven:
[...]
>
>>> Anything else confuses the casual reader. Perhaps the real question is whether
>>> the structures should have "helper" in their name in the first place?
>>
>> Those structures are meant for functions used by the helpers, they are not
>> helper functions.
>
> That might be how they started, but to me it looks like all these helpers
> are no longer helpers, but part of the core...
They are in library modules. You can write a DRM driver without
_helper_funcs, see i915. It's just a really hard sell to upstream nowadays.
Best regards
Thomas
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230921/5379f8c0/attachment.sig>
More information about the dri-devel
mailing list