[PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register

Andi Shyti andi.shyti at linux.intel.com
Wed Sep 27 07:04:05 UTC 2023


Hi Nirmoy,

On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote:
> On MTL GEN12_RING_FAULT_REG is not replicated so don't
> do mcr based operation for this register.
> 
> v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
> 
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>

This looks very good!

> -	if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> +	/*
> +	 * for media tile this ring fault register is not replicated
> +	 * so skip doing mcr ops on it.

Can we spare a few more words on "doing mcr ops on it"?

Andi


More information about the dri-devel mailing list