[PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Sep 27 22:35:10 UTC 2023
On Wed, Sep 27, 2023 at 05:09:23PM +0300, Jani Nikula wrote:
> On Wed, 27 Sep 2023, Laurent Pinchart wrote:
> > On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
> >> Make drm_bridge_get_edid() the one place to call the hook.
> >>
> >> Cc: Andrzej Hajda <andrzej.hajda at intel.com>
> >> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> >> Cc: Robert Foss <rfoss at kernel.org>
> >> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> >> Cc: Jonas Karlman <jonas at kwiboo.se>
> >> Cc: Jernej Skrabec <jernej.skrabec at gmail.com>
> >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> >>
> >> ---
> >>
> >> UNTESTED
> >
> > I can't test this either, but it looks fine.
>
> Thanks. Are you okay with merging the two with review only?
The changes are trivial, if we can't get anyone to test them, then I'm
OK merging them.
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >
> >> ---
> >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> index 22c84d29c2bc..7835738a532e 100644
> >> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
> >> unsigned int count;
> >> struct edid *edid;
> >>
> >> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
> >> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
> >> drm_connector_update_edid_property(connector, edid);
> >> count = drm_add_edid_modes(connector, edid);
> >> kfree(edid);
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list