[PATCH] drm/atomic: Perform blocking commits on workqueue

Ray Strode halfline at gmail.com
Thu Sep 28 19:33:46 UTC 2023


hI,

On Thu, Sep 28, 2023 at 11:05 AM Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
> Here's my earlier take on this: https://patchwork.freedesktop.org/series/108668/

Nice. Was there push back? Why didn't it go in?

> execpt I went further and moved the flush past the unlock in the end.

Is that necessary? I was wondering about that but there's this comment
in the code:

*  ... Locks, especially struct
 * &drm_modeset_lock, should not be held in worker threads or any other
 * asynchronous context used to commit the hardware state.

So it made me think there would be no locks held, and then I threw a
scratch build
at someone who reported it didn't deadlock and solved their issue.

--Ray


More information about the dri-devel mailing list