[PATCH 5/5] drm/vmwgfx: Sort primary plane formats by order of preference

[Pekka Paalanen]

On Tue,  2 Apr 2024 19:28:13 -0400
Zack Rusin <zack.rusin at broadcom.com> wrote:

> The table of primary plane formats wasn't sorted at all, leading to
> applications picking our least desirable formats by defaults.
> 
> Sort the primary plane formats according to our order of preference.

This is good.

> Fixes IGT's kms_atomic plane-invalid-params which assumes that the
> preferred format is a 32bpp format.

That sounds strange, why would IGT depend on preferred format being
32bpp?

That must be an oversight. IGT cannot dictate the format that hardware
must prefer. XRGB8888 is strongly suggested to be supported in general,
but why also preferred?


Thanks,
pq


> Signed-off-by: Zack Rusin <zack.rusin at broadcom.com>
> Fixes: 36cc79bc9077 ("drm/vmwgfx: Add universal plane support")
> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list at broadcom.com>
> Cc: dri-devel at lists.freedesktop.org
> Cc: <stable at vger.kernel.org> # v4.12+
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h
> index bf9931e3a728..bf24f2f0dcfc 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h
> @@ -233,10 +233,10 @@ struct vmw_framebuffer_bo {
>  
>  
>  static const uint32_t __maybe_unused vmw_primary_plane_formats[] = {
> -	DRM_FORMAT_XRGB1555,
> -	DRM_FORMAT_RGB565,
>  	DRM_FORMAT_XRGB8888,
>  	DRM_FORMAT_ARGB8888,
> +	DRM_FORMAT_RGB565,
> +	DRM_FORMAT_XRGB1555,
>  };
>  
>  static const uint32_t __maybe_unused vmw_cursor_plane_formats[] = {

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240403/acf9dfd6/attachment.sig>