[RESEND v7 06/37] sh: kernel/setup Update DT support.

[Rob Herring]

On Thu, Apr 4, 2024 at 12:15 AM Yoshinori Sato
<ysato at users.sourceforge.jp> wrote:
>
> Fix extrnal fdt initialize and bootargs.

What is the problem you are trying to solve?

And a typo.

>
> Signed-off-by: Yoshinori Sato <ysato at users.sourceforge.jp>
> ---
>  arch/sh/Kconfig             | 23 +++++++++++------------
>  arch/sh/include/asm/setup.h |  1 +
>  arch/sh/kernel/setup.c      | 36 +++++++++++++++++++++++-------------
>  3 files changed, 35 insertions(+), 25 deletions(-)
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 6711cde0d973..242cf30e704d 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -708,17 +708,22 @@ config ROMIMAGE_MMCIF
>           first part of the romImage which in turn loads the rest the kernel
>           image to RAM using the MMCIF hardware block.
>
> +config CMDLINE
> +       string "Kernel command line arguments string"
> +       default "console=ttySC1,115200"
> +
>  choice
>         prompt "Kernel command line"
> -       optional
> -       default CMDLINE_OVERWRITE
> -       depends on !OF || USE_BUILTIN_DTB
> +       default CMDLINE_BOOTLOADER
> +
> +config CMDLINE_BOOTLOADER
> +       bool "Use bootloader kernel arguments"

This should be the preferred, normal, default way. So why is it a user
visible option?

>         help
> -         Setting this option allows the kernel command line arguments
> -         to be set.
> +         Uses the command-line options passed by the boot loader.
> +         If boot loader dosen't provide kernel argments, Use built-in argments.

typos

bootloader in some spots, "boot loader" in others. Go with the former.

>
>  config CMDLINE_OVERWRITE
> -       bool "Overwrite bootloader kernel arguments"
> +       bool "Overwrite built-in kernel arguments"

The original made more sense to me. The default should be to use
bootloader args. Any built-in kernel command line should be prepend,
append (extend), or overwrite/replace.

Rob