[PATCH 1/3] drm/msm/dsi: remove the drm_bridge_attach fallback

[Abhinav Kumar]

On 4/5/2024 11:19 AM, Dmitry Baryshkov wrote:
> On Fri, 5 Apr 2024 at 21:17, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>>
>>
>>
>> On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote:
>>> On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>>>>
>>>>
>>>>
>>>> On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
>>>>> All the bridges that are being used with the MSM DSI hosts have been
>>>>> converted to support DRM_BRIDGE_ATTACH_NO_CONNECTOR. Drop the fallback
>>>>> code and require DRM_BRIDGE_ATTACH_NO_CONNECTOR to be supported by the
>>>>> downstream bridges.
>>>>>
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>>> ---
>>>>>     drivers/gpu/drm/msm/dsi/dsi_manager.c | 36 +++++++++++------------------------
>>>>>     1 file changed, 11 insertions(+), 25 deletions(-)
>>>>>
>>>>
>>>> There are the bridges I checked by looking at the dts:
>>>>
>>>> 1) lontium,lt9611
>>>> 2) lontium,lt9611uxc
>>>> 3) adi,adv7533
>>>> 4) ti,sn65dsi86
>>>>
>>>> Are there any more?
>>>>
>>>> If not, this LGTM
>>>>
>>>> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
>>>
>>>   From your message it looks more like Tested-by rather than just Reviewed-by
>>>
>>
>> No, I only cross-checked the dts.
>>
>> So, its only Reviewed-by :)
>>
>> But I wanted to list down all the bridges
> 
> Then I'd also nominate the panel bridge to the list of bridges for
> cross-checking. It is created automatically when we request a bridge,
> but DT has only a panel.
> 

Yes, that one is fine too

58 static int panel_bridge_attach(struct drm_bridge *bridge,
59 			       enum drm_bridge_attach_flags flags)
60 {
61 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
62 	struct drm_connector *connector = &panel_bridge->connector;
63 	int ret;
64
65 	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
66 		return 0;
67