[PATCH] staging: fbtft: fb_st7789v: support setting offset
Greg KH
gregkh at linuxfoundation.org
Tue Apr 9 17:36:18 UTC 2024
On Wed, Apr 10, 2024 at 01:28:06AM +0800, Yuguo Pei wrote:
> On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote:
> > So you are now hard-coding the size?
>
> Yes, the change just helps developers who want to adapt to different screen sizes.
So there is no change? I don't understand.
> > Is this always going to be 0, if so, why need it at all?
>
> Not sure. For example, when HEIGHT and WIDTH are 240 and 280, LEFT_OFFSET is 20 and TOP_OFFSET is 0. Different screens may have different offsets.
Then why is this needed?
Don't make changes that are not needed by anyone, especially for code in
drivers/staging/
>
> In addition, do I need to resend the patch to modify the Signed-off-by?
Of course you do :)
More information about the dri-devel
mailing list