[PATCH] drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Apr 10 13:28:43 UTC 2024


Hello Rob,

On Wed, Apr 10, 2024 at 03:10:26PM +0200, Robert Foss wrote:
> On Mon, 4 Mar 2024 10:05:56 +0100, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> > 
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback returning void
>       https://cgit.freedesktop.org/drm/drm-misc/commit/?id=29b39672bc1d

Great, do you feel like caring for its brother at

	https://lore.kernel.org/dri-devel/20240304091005.717012-2-u.kleine-koenig@pengutronix.de

, too?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240410/3d6052da/attachment-0001.sig>


More information about the dri-devel mailing list