[PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
Javier Martinez Canillas
javierm at redhat.com
Thu Apr 11 07:01:43 UTC 2024
Neil Armstrong <neil.armstrong at linaro.org> writes:
Hello Neal,
> On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
>> The MODULE_DEVICE_TABLE already creates proper alias for platform
>> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>>
>> ---
>>
>> Resent third time
>> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
>>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> Cc: Neil Armstrong <neil.armstrong at linaro.org>
>> ---
>> drivers/gpu/drm/armada/armada_drv.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
>> index e51ecc4f7ef4..f48e2cf8de43 100644
>> --- a/drivers/gpu/drm/armada/armada_drv.c
>> +++ b/drivers/gpu/drm/armada/armada_drv.c
>> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
>> MODULE_AUTHOR("Russell King <rmk+kernel at armlinux.org.uk>");
>> MODULE_DESCRIPTION("Armada DRM Driver");
>> MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:armada-drm");
>
> Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
>
> I think we'll need maxime or thomas ack to apply this via drm-misc-next
>
I don't think you need an explicit ack for them to commit it:
https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#merge-criteria
BTW, the patch looks good to me as well.
Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list