[PATCH 06/12] drm/msm/dpu: pull format flag definitions to msm_drv.h

[Abhinav Kumar]

On 4/11/2024 11:41 AM, Abhinav Kumar wrote:
> 
> 
> On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
>> In preparation to merger of formats databases, pull format flag
>> definitions to msm_drv.h header, so that they are visibile to both dpu
>> and mdp drivers.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98 ++++++++++-----------
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 28 ++----
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c |  4 +-
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c   |  4 +-
>>   drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c  |  8 +-
>>   drivers/gpu/drm/msm/disp/mdp_format.c       |  6 +-
>>   drivers/gpu/drm/msm/disp/mdp_kms.h          |  3 +-
>>   drivers/gpu/drm/msm/msm_drv.h               | 24 +++++
>>   8 files changed, 91 insertions(+), 84 deletions(-)
>>
> 
> <snip>
> 
>> +#define DPU_FORMAT_IS_YUV(X)        MSM_FORMAT_IS_YUV(&(X)->base)
>> +#define DPU_FORMAT_IS_DX(X)        MSM_FORMAT_IS_DX(&(X)->base)
>> +#define DPU_FORMAT_IS_LINEAR(X)        MSM_FORMAT_IS_LINEAR(&(X)->base)
>> +#define DPU_FORMAT_IS_TILE(X)        MSM_FORMAT_IS_TILE(&(X)->base)
>> +#define DPU_FORMAT_IS_UBWC(X)        MSM_FORMAT_IS_UBWC(&(X)->base)
> 
> Do we need another wrapper macro on top of MSM_FORMAT_*** macros? Why 
> cant we use them directly?
> 
> Same comment for MDP_FORMAT_IS_YUV macro as well.
> 
> Rest LGTM.

never mind, the next change does exactly this. Hence this one LGTM

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>