[v1,3/3] drm/panel: ili9341: Use predefined error codes

Sui Jingfeng sui.jingfeng at linux.dev
Tue Apr 30 16:54:08 UTC 2024


On 2024/4/25 22:26, Andy Shevchenko wrote:
> In one case the -1 is returned which is quite confusing code for
> the wrong device ID, in another the ret is returning instead of
> plain 0 that also confusing as readed may ask the possible meaning
> of positive codes, which are never the case there. Convert both
> to use explicit predefined error codes to make it clear what's going
> on there.
>
> Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


Reviewed-by: Sui Jingfeng <sui.jingfeng at linux.dev>


-- 
Best regards,
Sui



More information about the dri-devel mailing list