[PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

Krzysztof Niemiec krzysztof.niemiec at intel.com
Wed Aug 7 12:02:44 UTC 2024


On 2024-08-07 at 11:45:53 GMT, Andi Shyti wrote:
> By moving the pfn calculation to the set_address_limits()
> function we improve code readability. This way,
> set_address_limits() is responsible for calculating all memory
> mapping paramenters: "start", "end" and "pfn".
> 
> This suggestion from Jonathan was made during the review of
> commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping
> boundaries calculation"), which I liked, but it got lost on the
> way.
> 
> Suggested-by: Jonathan Cavitt <Jonathan.cavitt at intel.com>
> Signed-off-by: Andi Shyti <andi.shyti at linux.intel.com>
Reviewed-by: Krzysztof Niemiec <krzysztof.niemiec at intel.com>

Thanks
Krzysztof


More information about the dri-devel mailing list