[RFC PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Wed Aug 7 12:38:51 UTC 2024


Hi Doug

+cc Doug

I have seen that you have done some re-working and investigation on
drm stack, do you have some
suggestion on this case?

On Mon, Jun 24, 2024 at 8:53 PM Michael Trimarchi
<michael at amarulasolutions.com> wrote:
>
> The shutdown function can be called when the display is already
> unprepared. For example during reboot this trigger a kernel
> backlog. Calling the drm_panel_unprepare, allow us to avoid
> to trigger the kernel warning
>
> Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> ---
>
> It's not obviovus if shutdown can be dropped or this problem depends
> on the display stack as it is implmented. More feedback is required
> here
>
> ---
>  drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> index 169c629746c7..17349825543f 100644
> --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi)
>  {
>         struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
>
> -       r63353_panel_unprepare(&rpanel->base);
> +       drm_panel_unprepare(&rpanel->base);
>  }
>
>  static const struct r63353_desc sharp_ls068b3sx02_data = {
> --
> 2.43.0
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com


More information about the dri-devel mailing list