[PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static

neil.armstrong at linaro.org neil.armstrong at linaro.org
Mon Aug 19 15:34:32 UTC 2024


On 19/08/2024 14:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
> 
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning:
> 	symbol 'ts050_panel_data' was not declared. Should it be static?
> 
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning:
> 	symbol 'ts050v2_panel_data' was not declared. Should it be static?
> 
> These symbols are not used outside panel-khadas-ts050.c, so marks them static.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie at huawei.com>
> ---
>   drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> index 14932cb3defc..0e5e8e57bd1e 100644
> --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
> +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
>   	{0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
>   };
>   
> -struct khadas_ts050_panel_data ts050_panel_data = {
> +static struct khadas_ts050_panel_data ts050_panel_data = {
>   	.init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
>   	.len = ARRAY_SIZE(ts050_init_code)
>   };
>   
> -struct khadas_ts050_panel_data ts050v2_panel_data = {
> +static struct khadas_ts050_panel_data ts050v2_panel_data = {
>   	.init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
>   	.len = ARRAY_SIZE(ts050v2_init_code)
>   };

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the dri-devel mailing list