[PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

[Geert Uytterhoeven]

Hi Biju,

On Mon, Aug 5, 2024 at 6:22 PM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> The LCD controller is composed of Frame Compression Processor (FCPVD),
> Video Signal Processor (VSPD), and Display Unit (DU).
>
> It has DPI interface and supports a maximum resolution of WXGA along
> with 2 RPFs to support the blending of two picture layers and raster
> operations (ROPs).
>
> The DU module is connected to VSPD. Add RZ/G2UL DU support.
>
> Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> ---
> v2->v3:
>  * Avoided the line break in rzg2l_du_start_stop() for rstate.
>  * Replaced port->du_output in  struct rzg2l_du_output_routing and
>    dropped using the port number to indicate the output type in
>    rzg2l_du_encoders_init().
>  * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info

Thanks for your patch!

> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> @@ -183,8 +183,8 @@ static int rzg2l_du_encoders_init(struct rzg2l_du_device *rcdu)
>
>                 /* Find the output route corresponding to the port number. */
>                 for (i = 0; i < RZG2L_DU_OUTPUT_MAX; ++i) {
> -                       if (rcdu->info->routes[i].port == ep.port) {
> -                               output = i;
> +                       if (i == rcdu->info->routes[i].du_output) {
> +                               output = rcdu->info->routes[i].du_output;

Notwithstanding Laurent's comment, the above replacement is equivalent
to the original "output = i;", so there is no need to change this line.

>                                 break;
>                         }
>                 }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds