[PATCH v2 6/6] drm/vkms: Add missing check for CRTC initialization
Louis Chauvet
louis.chauvet at bootlin.com
Tue Aug 27 09:57:41 UTC 2024
CRTC initialization call drm_mode_crtc_set_gamma_size without the proper
checks, introduce this check.
Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
---
drivers/gpu/drm/vkms/vkms_crtc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index ff55099c86ce..39802c928bdf 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -293,7 +293,12 @@ struct vkms_crtc *vkms_crtc_init(struct vkms_device *vkmsdev, struct drm_plane *
}
drm_crtc_helper_add(&vkms_crtc->base, &vkms_crtc_helper_funcs);
- drm_mode_crtc_set_gamma_size(&vkms_crtc->base, VKMS_LUT_SIZE);
+ ret = drm_mode_crtc_set_gamma_size(&vkms_crtc->base, VKMS_LUT_SIZE);
+ if (ret) {
+ DRM_DEV_ERROR(vkmsdev->drm.dev, "Failed to set gamma size\n");
+ return ERR_PTR(ret);
+ }
+
drm_crtc_enable_color_mgmt(&vkms_crtc->base, 0, false, VKMS_LUT_SIZE);
spin_lock_init(&vkms_crtc->lock);
--
2.44.2
More information about the dri-devel
mailing list