[PATCH] drm/imagination: Use pvr_vm_context_get()

Matt Coster Matt.Coster at imgtec.com
Wed Aug 28 13:09:12 UTC 2024


I missed this open-coded kref_get() while trying to debug a refcount
bug, so let's use the helper function here to avoid that waste of time
again in the future.

Signed-off-by: Matt Coster <matt.coster at imgtec.com>
Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
---
  drivers/gpu/drm/imagination/pvr_vm.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_vm.c 
b/drivers/gpu/drm/imagination/pvr_vm.c
index e59517ba039e..ffd466509d0b 100644
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -636,9 +636,7 @@ pvr_vm_context_lookup(struct pvr_file *pvr_file, u32 
handle)
   	xa_lock(&pvr_file->vm_ctx_handles);
  	vm_ctx = xa_load(&pvr_file->vm_ctx_handles, handle);
-	if (vm_ctx)
-		kref_get(&vm_ctx->ref_count);
-
+	pvr_vm_context_get(vm_ctx);
  	xa_unlock(&pvr_file->vm_ctx_handles);
   	return vm_ctx;
-- 
2.46.0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240828/f274a649/attachment-0001.sig>


More information about the dri-devel mailing list