[PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

Helge Deller deller at gmx.de
Wed Aug 28 18:08:55 UTC 2024


On 8/8/24 11:46, Christophe JAILLET wrote:
> Use sysfs_emit_at() instead of snprintf() + custom logic.
> Using sysfs_emit_at() is much more simple.
>
> Also, sysfs_emit() is already used in this function, so using
> sysfs_emit_at() is more consistent.
>
> Also simplify the logic:
>    - always add a space after an entry
>    - change the last space into a '\n'
>
> Finally it is easy to see that, given the size of cabc_modes, PAGE_SIZE
> can not be reached.
> So better keep everything simple (and correct).
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>

applied.

Thanks!
Helge


More information about the dri-devel mailing list