[PATCH 4/6] drm/tegra: convert to struct drm_edid

Jani Nikula jani.nikula at intel.com
Thu Aug 29 11:43:16 UTC 2024


On Thu, 29 Aug 2024, Thierry Reding <thierry.reding at gmail.com> wrote:
> On Thu, Aug 22, 2024 at 08:42:50PM GMT, Jani Nikula wrote:
>> Prefer the struct drm_edid based functions for reading the EDID and
>> updating the connector.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>> 
>> ---
>> 
>> Cc: Thierry Reding <thierry.reding at gmail.com>
>> Cc: Mikko Perttunen <mperttunen at nvidia.com>
>> Cc: Jonathan Hunter <jonathanh at nvidia.com>
>> Cc: linux-tegra at vger.kernel.org
>> ---
>>  drivers/gpu/drm/tegra/drm.h    |  2 +-
>>  drivers/gpu/drm/tegra/output.c | 29 +++++++++++++++++------------
>>  2 files changed, 18 insertions(+), 13 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h
>> index 682011166a8f..2f3781e04b0a 100644
>> --- a/drivers/gpu/drm/tegra/drm.h
>> +++ b/drivers/gpu/drm/tegra/drm.h
>> @@ -133,7 +133,7 @@ struct tegra_output {
>>  	struct drm_bridge *bridge;
>>  	struct drm_panel *panel;
>>  	struct i2c_adapter *ddc;
>> -	const struct edid *edid;
>> +	const struct drm_edid *drm_edid;
>
> It perhaps might've been less confusing if this wasn't gratuitously
> renamed, but either way (and assuming you want to take this through
> drm-misc):

I've been doing that to ensure all call sites, especially kfree(), get
changed.

> Acked-by: Thierry Reding <treding at nvidia.com>

Thanks, pushed to drm-misc-next.

BR,
Jani.


-- 
Jani Nikula, Intel


More information about the dri-devel mailing list