[PATCH v4 4/9] ASoC: rcar_snd: use new of_graph functions
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Thu Aug 29 23:15:07 UTC 2024
Hi Rob
Thank you for your review
> > @@ -1277,16 +1277,12 @@ static int rsnd_dai_of_node(struct rsnd_priv *priv, int *is_graph)
> > /*
> > * Audio-Graph-Card
> > */
> > - for_each_child_of_node(np, ports) {
> > - if (!of_node_name_eq(ports, "ports") &&
> > - !of_node_name_eq(ports, "port"))
> > - continue;
> > - priv->component_dais[i] = of_graph_get_endpoint_count(ports);
> > + for_each_of_graph_ports(np, ports) {
> > + priv->component_dais[i] = of_graph_get_port_count(ports);
>
> These are not equivalent. Besides now working with multiple 'ports'
> nodes, it's possible to have a port node without an endpoint populated
> for example.
This is the driver I maintain.
This code checks how many "port" node exists, because it needs to
manage data connection based on each "port".
The code was a little bit changed, but becomes more readable,
and was tested on my board.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the dri-devel
mailing list