[PATCH] drm/vmwgfx: Remove initialization of connector status

[Zack Rusin]

On Mon, Dec 2, 2024 at 2:55 AM Thomas Zimmermann <tzimmermann at suse.de> wrote:
>
> ping for review
>
>
> Am 05.11.24 um 14:20 schrieb Thomas Zimmermann:
> > Remove the connector-status initialization from several of vmwgfx's
> > functions. It is not required by the driver or DRM helpers.
> >
> > DRM initializes the connector to unknown status in __drm_connector_init()
> > and reads the physical status when DRM clients or the user needs the
> > information, or if it detects/polls a change to the status.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> > ---
> >   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  | 1 -
> >   drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 1 -
> >   drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 1 -
> >   3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> > index 39949e0a493f..f0b429525467 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> > @@ -479,7 +479,6 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
> >       }
> >
> >       drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
> > -     connector->status = vmw_du_connector_detect(connector, true);
> >
> >       ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
> >                              DRM_MODE_ENCODER_VIRTUAL, NULL);
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> > index 0f4bfd98480a..32029d80b72b 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> > @@ -868,7 +868,6 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit)
> >       }
> >
> >       drm_connector_helper_add(connector, &vmw_sou_connector_helper_funcs);
> > -     connector->status = vmw_du_connector_detect(connector, true);
> >
> >       ret = drm_encoder_init(dev, encoder, &vmw_screen_object_encoder_funcs,
> >                              DRM_MODE_ENCODER_VIRTUAL, NULL);
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> > index 82d18b88f4a7..114a75069e1c 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> > @@ -1593,7 +1593,6 @@ static int vmw_stdu_init(struct vmw_private *dev_priv, unsigned unit)
> >       }
> >
> >       drm_connector_helper_add(connector, &vmw_stdu_connector_helper_funcs);
> > -     connector->status = vmw_du_connector_detect(connector, false);
> >
> >       ret = drm_encoder_init(dev, encoder, &vmw_stdu_encoder_funcs,
> >                              DRM_MODE_ENCODER_VIRTUAL, NULL);
>

Thank you. Looks good.

Reviewed-by: Zack Rusin <zack.rusin at broadcom.com>

z
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5427 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20241202/3195ac42/attachment.bin>