[PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

[Jeffrey Hugo]

On 12/5/2024 8:44 AM, Mike Lothian wrote:
> Hi
> 
> I needed to add the following to get things compiling for me
> 
> 
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c
> b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index fe684f463b945..79b9801935e71 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -6,6 +6,7 @@
> #include <drm/drm_device.h>
> #include <drm/drm_managed.h>
> #include <linux/bitfield.h>
> +#include <linux/interrupt.h>
> #include <linux/iopoll.h>

Looking at the code, this is valid.  However, I'm not sure why this is 
broken for you and not others.  Do you have any ideas?  How are you 
building this?  Is the tree and/or defconfig unique in some way?

> #define CREATE_TRACE_POINTS
> 
> 
> I also had to rename the firmware in /lib/firmware/amdnpu/1502_00/
> from npu.sbin.1.5.2.380 to npu.sbin
> 
> Cheers
> 
> Mike
>