[RFC 03/24] drm/gpuvm: Remove bogus lock assert
Rob Clark
robdclark at gmail.com
Sat Dec 7 16:15:03 UTC 2024
From: Rob Clark <robdclark at chromium.org>
If the driver is using an external mutex to synchronize vm access, it
doesn't need to hold vm->r_obj->resv. And if the driver is already
holding obj->resv, then needing to pointlessly grab vm->r_obj->resv will
be seen by lockdep as nested locking.
Signed-off-by: Rob Clark <robdclark at chromium.org>
---
drivers/gpu/drm/drm_gpuvm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index 1e89a98caad4..c9bf18119a86 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -1505,9 +1505,6 @@ drm_gpuvm_bo_destroy(struct kref *kref)
struct drm_gem_object *obj = vm_bo->obj;
bool lock = !drm_gpuvm_resv_protected(gpuvm);
- if (!lock)
- drm_gpuvm_resv_assert_held(gpuvm);
-
drm_gpuvm_bo_list_del(vm_bo, extobj, lock);
drm_gpuvm_bo_list_del(vm_bo, evict, lock);
--
2.47.1
More information about the dri-devel
mailing list