[PATCH v2 1/3] drm/vmwgfx: Introduce userspace managed surfaces

[Maaz Mombasawala]

On 11/19/24 11:38, Zack Rusin wrote:

>>  bool vmw_cmd_describe(const void *buf, u32 *size, char const **cmd)
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
>> index 835d1eed8dd9..cfa14a34a679 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
>> @@ -112,6 +112,9 @@ int vmw_getparam_ioctl(struct drm_device *dev, void *data,
>>         case DRM_VMW_PARAM_DEVICE_ID:
>>                 param->value = to_pci_dev(dev_priv->drm.dev)->device;
>>                 break;
>> +       case DRM_VMW_PARAM_USER_SRF:
>> +               param->value = 1;
>> +               break;
> 
> We probably should shield this with has_sm5_context and
> SVGA_CAP_GBOBJECTS, right? Otherwise the commands will start failing.
> 
> z

We can shield this with SVGA_CAP_GBOBJECTS, but sm5_context is not needed.
The third patch of this series "drm/vmwgfx: Add support for older define commands
for userspace surfaces" adds support for V3 and V2 of the surface creation command,
V3 is invoked for sm4.1 and V2 for sm4.

-- 
Maaz Mombasawala <maaz.mombasawala at broadcom.com>