[PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

[Jeffrey Hugo]

On 12/13/2024 10:02 AM, Lizhi Hou wrote:
> 
> On 12/13/24 08:58, Jeffrey Hugo wrote:
>> On 12/6/2024 3:00 PM, Lizhi Hou wrote:
>>> The latest released firmware supports reading firmware interface version
>>> from registers directly. The driver's probe routine reads the major and
>>> minor version numbers. If the firmware interface does not compatible 
>>> with
>>> the driver, the driver's probe routine returns failure.
>>>
>>> Co-developed-by: Min Ma <min.ma at amd.com>
>>> Signed-off-by: Min Ma <min.ma at amd.com>
>>> Signed-off-by: Lizhi Hou <lizhi.hou at amd.com>
>>> ---
>>>   drivers/accel/amdxdna/aie2_message.c | 26 ----------
>>>   drivers/accel/amdxdna/aie2_pci.c     | 74 ++++++++++++++++++++++------
>>>   drivers/accel/amdxdna/aie2_pci.h     |  6 +--
>>>   drivers/accel/amdxdna/npu1_regs.c    |  2 +-
>>>   drivers/accel/amdxdna/npu2_regs.c    |  2 +-
>>>   drivers/accel/amdxdna/npu4_regs.c    |  2 +-
>>>   drivers/accel/amdxdna/npu5_regs.c    |  2 +-
>>
>> Do you need an update to npu6_regs?
> 
> npu6_regs is added with upstream fw minor already. Thus, it does not 
> need an update.

Ok.

Reviewed-by: Jeffrey Hugo <quic_jhugo at quicinc.com>

I'm expecting to see a v3 based on the other review feedback. Let me 
know if this is incorrect.

-Jeff