[PATCH 1/2] accel/amdxdna: use modern PM helpers
Jeffrey Hugo
quic_jhugo at quicinc.com
Fri Dec 13 18:11:00 UTC 2024
On 12/13/2024 10:57 AM, Lizhi Hou wrote:
>
> On 12/13/24 09:49, Jeffrey Hugo wrote:
>> On 12/13/2024 10:41 AM, Lizhi Hou wrote:
>>>
>>> On 12/13/24 09:07, Jeffrey Hugo wrote:
>>>> On 12/13/2024 2:02 AM, Arnd Bergmann wrote:
>>>>> From: Arnd Bergmann <arnd at arndb.de>
>>>>>
>>>>> The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause
>>>>> a build
>>>>> warning when CONFIG_PM is disabled:
>>>>>
>>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error:
>>>>> 'amdxdna_pmops_resume' defined but not used [-Werror=unused-function]
>>>>> 343 | static int amdxdna_pmops_resume(struct device *dev)
>>>>> | ^~~~~~~~~~~~~~~~~~~~
>>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:328:12: error:
>>>>> 'amdxdna_pmops_suspend' defined but not used [-Werror=unused-function]
>>>>> 328 | static int amdxdna_pmops_suspend(struct device *dev)
>>>>> | ^~~~~~~~~~~~~~~~~~~~~
>>>>>
>>>>> Change these to the modern replacements.
>>>>>
>>>>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>>>>
>>>> Looks sane to me.
>>>>
>>>> Lizhi, can you verify that this works as expected for you? I'd hate
>>>> to accidentally break something.
>>>
>>> Verified suspend/resume. It works fine.
>>
>> Excellent. Would you like to give a reviewed-by and/or a tested-by?
>
> Reviewed-by: Lizhi Hou <lizhi.hou at amd.com>
>
> Tested-by: Lizhi Hou <lizhi.hou at amd.com>
Thanks!
Pushed to drm-misc-next
-Jeff
More information about the dri-devel
mailing list