[PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

[Imre Deak]

On Mon, Dec 16, 2024 at 01:03:42PM +0200, Jani Nikula wrote:
> On Fri, 13 Dec 2024, Imre Deak <imre.deak at intel.com> wrote:
> > On Thu, Dec 12, 2024 at 12:12:15PM +0200, Jani Nikula wrote:
> >> On Thu, 12 Dec 2024, Imre Deak <imre.deak at intel.com> wrote:
> >> > MST connectors should be initialized/registered by calling
> >> > drm_connector_dynamic_init()/drm_connector_dynamic_register(). The
> >> > previous patch adding these functions explains the issue with the
> >> 
> >> References to "previous patch" become meaningless after this has been
> >> committed.
> >
> > Ok, will change it to: "The patch adding these functions ...".
> 
> In 99% cases having the word "patch" in a commit message is just
> wrong...

Ok, will use "commit", unless you suggest another way.

> 
> BR,
> Jani.
> 
> >
> >> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> >> 
> >> > current drm_connector_init*()/drm_connector_register() interface for
> >> > MST connectors.
> >> >
> >> > Based on the above adjust here the registration part and change the
> >> > initialization part in follow-up patches for each driver.
> >> >
> >> > For now, drivers are allowed to keep using the drm_connector_init*()
> >> > functions, by drm_connector_dynamic_register() checking for this (see
> >> > drm_connector_add()). A patch later will change this to WARN in such
> >> > cases.
> >> >
> >> > Cc: Lyude Paul <lyude at redhat.com>
> >> > Cc: Harry Wentland <harry.wentland at amd.com>
> >> > Cc: Leo Li <sunpeng.li at amd.com>
> >> > Cc: Wayne Lin <wayne.lin at amd.com>
> >> > Cc: Alex Deucher <alexander.deucher at amd.com>
> >> > Cc: Karol Herbst <kherbst at redhat.com>
> >> > Cc: Danilo Krummrich <dakr at kernel.org>
> >> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> >> > ---
> >> >  drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> >> > index 687c70308d82b..f8cd094efa3c0 100644
> >> > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> >> > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> >> > @@ -2281,7 +2281,7 @@ drm_dp_mst_port_add_connector(struct drm_dp_mst_branch *mstb,
> >> >  		port->cached_edid = drm_edid_read_ddc(port->connector,
> >> >  						      &port->aux.ddc);
> >> >  
> >> > -	drm_connector_register(port->connector);
> >> > +	drm_connector_dynamic_register(port->connector);
> >> >  	return;
> >> >  
> >> >  error:
> >> 
> >> -- 
> >> Jani Nikula, Intel
> 
> -- 
> Jani Nikula, Intel