[PATCH v4 05/25] drm/msm/dpu: get rid of struct dpu_rm_requirements

[Abhinav Kumar]

On 12/16/2024 5:26 PM, Dmitry Baryshkov wrote:
> On Mon, Dec 16, 2024 at 04:43:16PM -0800, Jessica Zhang wrote:
>> From: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>
>> The struct dpu_rm_requirements was used to wrap display topology and
>> hw resources, which meant INTF indices. As of commit ef58e0ad3436
>> ("drm/msm/dpu: get INTF blocks directly rather than through RM") the hw
>> resources struct was removed, leaving struct dpu_rm_requirements
>> containing a single field (topology). Remove the useless wrapper.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> Signed-off-by: Jessica Zhang <quic_jesszhan at quicinc.com>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c |  2 +-
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c      | 71 ++++++++++-------------------
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h      |  2 +-
>>   3 files changed, 25 insertions(+), 50 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> index 83de7564e2c1fe14fcf8c4f82335cafc937e1b99..5172ab4dea995a154cd88d05c3842d7425fc34ce 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> @@ -800,7 +800,7 @@ static int dpu_encoder_virt_atomic_check(
>>   
>>   		if (!crtc_state->active_changed || crtc_state->enable)
>>   			ret = dpu_rm_reserve(&dpu_kms->rm, global_state,
>> -					drm_enc, crtc_state, topology);
>> +					drm_enc, crtc_state, &topology);
>>   		if (!ret)
>>   			dpu_encoder_assign_crtc_resources(dpu_kms, drm_enc,
>>   							  global_state, crtc_state);
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>> index c247af03dc8ef7174eedf3d5cc267d64f17a8656..cd5960af4a151428cc6fb7154c3ffdb65ebcf287 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
>> @@ -5,6 +5,7 @@
>>    */
>>   
>>   #define pr_fmt(fmt)	"[drm:%s] " fmt, __func__
>> +#include "msm_drv.h"
> 
> Why is it necessary? struct msm_display_topology has been moved to
> dpu_rm.h
> 

Yeah, will be good to check and drop this as its unnecessary. With that 
fixed, this LGTM

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>