[PATCH 40/46] dma-buf: move dma-buf symbols into the DMA_BUF module namespace.

[Kolanupaka Naveena]

Hi Greg,

Thanks for your inputs and patience in reviewing the patch.
By mistakenly this internal patch has been sent for review as the reference commit ID is from opensource, email has been sent to those who are all involved in that commit.
Please ignore this patch as it is for internal usage.

Thanks and Regards

Kolanupaka Naveena
Graphics Software Engineer | GSE OSGC
M +918374415216
Intel Corporation | intel.com

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Sent: Friday, February 2, 2024 9:46 PM
> To: Kolanupaka Naveena <kolanupaka.naveena at intel.com>
> Cc: gfx-internal-devel at eclists.intel.com; Wilson, Chris P
> <chris.p.wilson at intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>;
> Muqthyar Ahmed, Syed Abdul <syed.abdul.muqthyar.ahmed at intel.com>;
> Sagar Chormale <sagar.chormale at intel.com>; Pan, Xinhui
> <Xinhui.Pan at amd.com>; David Airlie <airlied at linux.ie>; Maarten Lankhorst
> <maarten.lankhorst at linux.intel.com>; Maxime Ripard <mripard at kernel.org>;
> Thomas Zimmermann <tzimmermann at suse.de>; Mauro Carvalho Chehab
> <mchehab at kernel.org>; dri-devel at lists.freedesktop.org; Daniel Vetter
> <daniel.vetter at ffwll.ch>; Christian König <christian.koenig at amd.com>; Arnd
> Bergmann <arnd at arndb.de>; Sumit Semwal <sumit.semwal at linaro.org>;
> Alex Deucher <alexander.deucher at amd.com>
> Subject: Re: [PATCH 40/46] dma-buf: move dma-buf symbols into the
> DMA_BUF module namespace.
> 
> On Fri, Feb 02, 2024 at 02:01:47PM +0530, Kolanupaka Naveena wrote:
> > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> > +#include <linux/module.h>
> > +#endif
> 
> No #ifdef in .c files please, this should not be an issue, just include the .h file.
> 
> >  #include <drm/intel_iaf_platform.h>
> >
> >  #include "gem/i915_gem_dmabuf.h"
> > @@ -23,6 +26,10 @@
> >  #include "i915_trace.h"
> >  #include "intel_iaf.h"
> >
> > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> > +MODULE_IMPORT_NS(DMA_BUF);
> > +#endif
> 
> Why is a #ifdef needed here?  If this isn't built as a module, it's not an issue,
> please just make it simpler.
> 
> But really, why is this a #define at all in the first place?
> 
> thanks,
> 
> greg k-h