[PATCH] drm: renesas: rz-du: Fix redefinition errors related to rzg2l_du_vsp_*()

Biju Das biju.das.jz at bp.renesas.com
Thu Feb 22 10:56:33 UTC 2024


Hi Maxime Ripard,

> -----Original Message-----
> From: Maxime Ripard <mripard at kernel.org>
> Sent: Thursday, February 22, 2024 10:14 AM
> Subject: Re: [PATCH] drm: renesas: rz-du: Fix redefinition errors related
> to rzg2l_du_vsp_*()
> 
> Hi,
> 
> Thanks for working on this
> 
> On Thu, Feb 22, 2024 at 09:56:30AM +0000, Biju Das wrote:
> > Fix the redefinition errors for the below functions on x86 by
> > replacing
> > CONFIG_DRM_RCAR_VSP->IS_ENABLED(CONFIG_VIDEO_RENESAS_VSP1) and adding
> > EXPORT_SYMBOL_GPL for all:
> >  1) rzg2l_du_vsp_init()
> >  2) rzg2l_du_vsp_enable()
> >  3) rzg2l_du_vsp_disable()
> >  4) rzg2l_du_vsp_atomic_flush()
> >  5) rzg2l_du_vsp_get_drm_plane()
> 
> This really should be two patches: you're fixing some symbols not being
> exported (because they need to be called by what other module?) 

I Just realized that ,this export symbols are not required as they are used
within the single module. So no need to export. 

So, I will send a single patch with fixing redefinition error.

Cheers,
Biju




More information about the dri-devel mailing list