[PATCH] drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port

Enric Balletbo i Serra eballetb at redhat.com
Wed Feb 28 23:11:59 UTC 2024


Hello Andrew,

Many thanks for proposing this.

On Wed, Feb 28, 2024 at 11:02 PM Javier Martinez Canillas
<javierm at redhat.com> wrote:
>
> Andrew Halaney <ahalaney at redhat.com> writes:
>
> Hello Andrew,
>
> > This gets logged out to /sys/kernel/debug/devices_deferred in the
> > -EPROBE_DEFER case and as an error otherwise. The message here provides
> > useful information to the user when troubleshooting why their display is
> > not working in either case, so let's make it output appropriately.
> >
> > Signed-off-by: Andrew Halaney <ahalaney at redhat.com>
> > ---
> > There's definitely more spots in this driver that could be upgraded from
> > dev_dbg() to something more appropriate, but this one burned me today so
> > I thought I'd send a patch for it specifically before I forget.
> > ---
>
> Makes sense to me and I agree that's useful to have that information there.
>
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
>

Logging in  /sys/kernel/debug/devices_deferred was useful for me, so

Tested-by: Enric Balletbo i Serra <eballetbo at kernel.org>

Cheers,
  Enric

> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>



More information about the dri-devel mailing list