[v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

[Ritesh Kumar]

Hi Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>Sent: Friday, December 22, 2023 9:02 PM
>To: Ritesh Kumar (QUIC) <quic_riteshk at quicinc.com>; dri-
>devel at lists.freedesktop.org; devicetree at vger.kernel.org; linux-
>kernel at vger.kernel.org
>Cc: neil.armstrong at linaro.org; Jessica Zhang (QUIC)
><quic_jesszhan at quicinc.com>; sam at ravnborg.org;
>maarten.lankhorst at linux.intel.com; mripard at kernel.org;
>tzimmermann at suse.de; airlied at gmail.com; daniel at ffwll.ch;
>robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org; conor+dt at kernel.org;
>Abhinav Kumar (QUIC) <quic_abhinavk at quicinc.com>; Rajeev Nandan (QUIC)
><quic_rajeevny at quicinc.com>; Vishnuvardhan Prodduturi (QUIC)
><quic_vproddut at quicinc.com>
>Subject: Re: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI
>panel
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 22/12/2023 12:07, Ritesh Kumar wrote:
>> Document Truly NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <quic_riteshk at quicinc.com>
>> ---
>>  .../display/panel/truly,nt36672e.yaml         | 66 +++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> new file mode 100644
>> index 000000000000..39ab05c5b103
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.y
>> +++ aml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Truly NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> +  - Ritesh Kumar <quic_riteshk at quicinc.com>
>> +
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: truly,nt36672e
>
>Eee? This is existing Novatek, isn't it?

This is novatek nt36672e panel. Existing novatek is nt36672a panel.
They differ in resolution, power on/off sequence (init sequence, delays), panel reset sequence.
NT36672E panel supports refresh rates of 60Hz, 90Hz, 120Hz and 144Hz. It also supports DSC.
To start with, I have added support for uncompressed 60Hz. In subsequent patches, other configurations
support will be added.

>
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: DSI virtual channel
>> +
>> +  vddi-supply: true
>> +  avdd-supply: true
>> +  avee-supply: true
>> +  port: true
>> +  reset-gpios: true
>> +  backlight: true
>> +
>> +additionalProperties: false
>
>
>This goes after required:.

Thanks, will change in next version.

Thanks,
Ritesh