[PATCH] drm/mgag200: Fix caching setup for remapped video memory
Jocelyn Falempe
jfalempe at redhat.com
Fri Jan 5 10:41:05 UTC 2024
Hi,
On 05/01/2024 09:25, Thomas Zimmermann wrote:
> I/O video memory for the framebuffer supports write-combine caching
> mode. Simplify the driver's code that sets up the caching mode.
>
> * Map video memory with ioremap_wc(), which automatically sets up
> the PAT entry with write-combine caching.
>
> * Remove the now obsolete call to devm_arch_io_reserve_memtype_wc().
> It is only required to mmap the video memory to user space, which the
> driver doesn't do.
>
> * According to the PAT documentation, arch_phys_wc_add() is best
> called after remapping I/O memory, so move it after ioremap.
>
Thanks a lot for taking some time to look at the latency issue.
This looks good to me.
Reviewed-by: Jocelyn Falempe <jfalempe at redhat.com>
--
Jocelyn
More information about the dri-devel
mailing list