[PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip AC40T08A MIPI Display panel

[Conor Dooley]

On Tue, Jul 02, 2024 at 04:47:39AM +0000, Manikandan.M at microchip.com wrote:
> Hi Conor,
> 
> On 01/07/24 3:33 pm, Conor Dooley wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > 
> > ForwardedMessage.eml
> > 
> > Subject:
> > Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip 
> > AC40T08A MIPI Display panel
> > From:
> > Conor Dooley <conor at kernel.org>
> > Date:
> > 01/07/24, 3:33 pm
> > 
> > To:
> > Manikandan Muralidharan <manikandan.m at microchip.com>
> > CC:
> > megi at xff.cz, javierm at redhat.com, neil.armstrong at linaro.org, 
> > quic_jesszhan at quicinc.com, sam at ravnborg.org, airlied at gmail.com, 
> > daniel at ffwll.ch, maarten.lankhorst at linux.intel.com, mripard at kernel.org, 
> > tzimmermann at suse.de, robh at kernel.org, krzk+dt at kernel.org, 
> > conor+dt at kernel.org, dri-devel at lists.freedesktop.org, 
> > devicetree at vger.kernel.org, linux-kernel at vger.kernel.org
> > 
> > 

btw, please fix your mail client :/

> > On Mon, Jul 01, 2024 at 02:28:35PM +0530, Manikandan Muralidharan wrote:
> >> Add compatible string for the Microchip's AC40T08A MIPI Display
> >> panel.This panel uses a Himax HX8394 display controller.
> >> The reset line is not populated and leads to driver probe issues,
> >> thus add conditional block to narrow reset-gpio property per variant.
> > I really should have asked on v1, but I wasn't sure whether or not the
> > optional nature of the reset-gpios was specific to your new panel so I
> > held off: Is it ever the case that a reset-gpio can be provided for this
> > microchip panel, or just not in the configuration you tested? If it is
> > never possible, then I'd probably do...
> The reset-gpio line can be provided for the microchip MIPI panel, the 
> SoC variant in which I tested did not have the reset line configured, 
> hence had to make it optional here and also in the driver to avoid panel 
> probe issues.

Okay, then:
Reviewed-by: Conor Dooley <conor.dooley at microchip.com>

Thanks,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240702/16b1bc14/attachment.sig>