[PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true
Maxime Ripard
mripard at kernel.org
Mon Jul 8 08:53:30 UTC 2024
Hi,
On Mon, Jul 08, 2024 at 09:27:09AM GMT, Biju Das wrote:
> The pm_runtime_resume_and_get() returns 1 if RPM is active, in this
> case it won't call a put. This will result in PM imbalance as it
> treat this as an error and propagate this to caller and the caller
> never calls corresponding put(). Fix this issue by checking error
> condition only.
>
> Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> ---
> drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> index 2e2f37b9d0a4..42a5d6876bec 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> @@ -208,7 +208,7 @@ static void shmob_drm_crtc_atomic_enable(struct drm_crtc *crtc,
> int ret;
>
> ret = pm_runtime_resume_and_get(dev);
> - if (ret)
> + if (ret < 0)
> return;
The documentation of pm_runtime_resume_and_get says that:
Resume @dev synchronously and if that is successful, increment its
runtime PM usage counter. Return 0 if the runtime PM usage counter of
@dev has been incremented or a negative error code otherwise.
So it looks like it can't return 1, ever. Are you sure you're not
confusing pm_runtime_resume_and_get with pm_runtime_get?
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240708/c17c24a8/attachment.sig>
More information about the dri-devel
mailing list