[PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if RPM_ACTIVE
Biju Das
biju.das.jz at bp.renesas.com
Mon Jul 8 09:18:49 UTC 2024
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert at linux-m68k.org>
> Sent: Monday, July 8, 2024 10:11 AM
> Subject: Re: [PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if RPM_ACTIVE
>
> Hi Biju,
>
> On Mon, Jul 8, 2024 at 10:22 AM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> > The pm_runtime_resume_and_get() returns 1 if RPM is active, in this
> > case it won't call a put. This will result in PM imbalance as it treat
> > this as an error and propagate this to caller and the caller never
> > calls corresponding put(). Fix this issue by checking error condition
> > only.
> >
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
>
> Thanks for your patch, but the code for pm_runtime_resume_and_get() seems to disagree?
> https://elixir.bootlin.com/linux/latest/source/include/linux/pm_runtime.h#L436
Oops. Missed that. Sorry for the noisy patch.
Cheers,
Biju
More information about the dri-devel
mailing list