[PATCH 06/12] drm/v3d: Move part of copying of reset/copy performance extension to a helper

[Maíra Canal]

On 7/10/24 10:41, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> 
> The loop which looks up the syncobj and copies the kperfmon ids is
> identical so lets move it to a helper.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> ---
>   drivers/gpu/drm/v3d/v3d_submit.c | 148 +++++++++++++------------------
>   1 file changed, 64 insertions(+), 84 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_submit.c b/drivers/gpu/drm/v3d/v3d_submit.c
> index b51600e236c8..35682433f75b 100644
> --- a/drivers/gpu/drm/v3d/v3d_submit.c
> +++ b/drivers/gpu/drm/v3d/v3d_submit.c
> @@ -641,13 +641,63 @@ v3d_get_cpu_copy_query_results_params(struct drm_file *file_priv,
>   	return err;
>   }
>   
> +static int

Could you prefix the name of this function with `v3d_`?

> +copy_query_info(struct v3d_performance_query_info *qinfo,
> +		unsigned int count,
> +		unsigned int nperfmons,
> +		u32 __user *syncs,
> +		u64 __user *kperfmon_ids,
> +		struct drm_file *fpriv)

Nit: s/fpriv/file_priv

> +{
> +	unsigned int i, j;
> +	int err;
> +
> +	for (i = 0; i < count; i++) {
> +		struct v3d_performance_query *query = &qinfo->queries[i];
> +		u32 __user *ids_pointer;
> +		u32 sync, id;
> +		u64 ids;
> +
> +		if (get_user(sync, syncs++)) {

Could you mention on the commit message that now you are using
`get_user()`?


> +			err = -EFAULT;
> +			goto error;
> +		}
> +
> +		if (get_user(ids, kperfmon_ids++)) {
> +			err = -EFAULT;
> +			goto error;
> +		}
> +
> +		ids_pointer = u64_to_user_ptr(ids);
> +
> +		for (j = 0; j < nperfmons; j++) {
> +			if (get_user(id, ids_pointer++)) {
> +				err = -EFAULT;
> +				goto error;
> +			}
> +
> +			query->kperfmon_ids[j] = id;
> +		}
> +
> +		query->syncobj = drm_syncobj_find(fpriv, sync);
> +		if (!query->syncobj) {
> +			err = -ENOENT;
> +			goto error;
> +		}
> +	}
> +
> +	return 0;
> +
> +error:
> +	__v3d_performance_query_info_free(qinfo, i);
> +	return err;
> +}
> +
>   static int
>   v3d_get_cpu_reset_performance_params(struct drm_file *file_priv,
>   				     struct drm_v3d_extension __user *ext,
>   				     struct v3d_cpu_job *job)
>   {
> -	u32 __user *syncs;
> -	u64 __user *kperfmon_ids;
>   	struct drm_v3d_reset_performance_query reset;
>   	int err;
>   
> @@ -675,50 +725,17 @@ v3d_get_cpu_reset_performance_params(struct drm_file *file_priv,
>   	if (!job->performance_query.queries)
>   		return -ENOMEM;
>   
> -	syncs = u64_to_user_ptr(reset.syncs);
> -	kperfmon_ids = u64_to_user_ptr(reset.kperfmon_ids);
> +	err = copy_query_info(qinfo, reset.count, reset.nperfmons,
> +			      u64_to_user_ptr(reset.syncs),
> +			      u64_to_user_ptr(reset.kperfmon_ids),
> +			      file_priv);

I'm missing where `qinfo` is being declared.

> +	if (err)
> +		return err;
>   
> -	for (int i = 0; i < reset.count; i++) {
> -		u32 sync;
> -		u64 ids;
> -		u32 __user *ids_pointer;
> -		u32 id;
> -
> -		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
> -			err = -EFAULT;
> -			goto error;
> -		}
> -
> -		if (copy_from_user(&ids, kperfmon_ids++, sizeof(ids))) {
> -			err = -EFAULT;
> -			goto error;
> -		}
> -
> -		ids_pointer = u64_to_user_ptr(ids);
> -
> -		for (int j = 0; j < reset.nperfmons; j++) {
> -			if (copy_from_user(&id, ids_pointer++, sizeof(id))) {
> -				err = -EFAULT;
> -				goto error;
> -			}
> -
> -			job->performance_query.queries[i].kperfmon_ids[j] = id;
> -		}
> -
> -		job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
> -		if (!job->performance_query.queries[i].syncobj) {
> -			err = -ENOENT;
> -			goto error;
> -		}
> -	}
>   	job->performance_query.count = reset.count;
>   	job->performance_query.nperfmons = reset.nperfmons;
>   
>   	return 0;
> -
> -error:
> -	__v3d_performance_query_info_free(qinfo, i);
> -	return err;
>   }
>   
>   static int
> @@ -726,8 +743,6 @@ v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv,
>   					  struct drm_v3d_extension __user *ext,
>   					  struct v3d_cpu_job *job)
>   {
> -	u32 __user *syncs;
> -	u64 __user *kperfmon_ids;
>   	struct drm_v3d_copy_performance_query copy;
>   	int err;
>   
> @@ -758,44 +773,13 @@ v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv,
>   	if (!job->performance_query.queries)
>   		return -ENOMEM;
>   
> -	syncs = u64_to_user_ptr(copy.syncs);
> -	kperfmon_ids = u64_to_user_ptr(copy.kperfmon_ids);
> +	err = copy_query_info(qinfo, copy.count, copy.nperfmons,
> +			      u64_to_user_ptr(copy.syncs),
> +			      u64_to_user_ptr(copy.kperfmon_ids),
> +			      file_priv);

Same here.

Best Regards,
- Maíra

> +	if (err)
> +		return err;
>   
> -	for (int i = 0; i < copy.count; i++) {
> -		u32 sync;
> -		u64 ids;
> -		u32 __user *ids_pointer;
> -		u32 id;
> -
> -		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
> -			err = -EFAULT;
> -			goto error;
> -		}
> -
> -		job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
> -
> -		if (copy_from_user(&ids, kperfmon_ids++, sizeof(ids))) {
> -			err = -EFAULT;
> -			goto error;
> -		}
> -
> -		ids_pointer = u64_to_user_ptr(ids);
> -
> -		for (int j = 0; j < copy.nperfmons; j++) {
> -			if (copy_from_user(&id, ids_pointer++, sizeof(id))) {
> -				err = -EFAULT;
> -				goto error;
> -			}
> -
> -			job->performance_query.queries[i].kperfmon_ids[j] = id;
> -		}
> -
> -		job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
> -		if (!job->performance_query.queries[i].syncobj) {
> -			err = -ENOENT;
> -			goto error;
> -		}
> -	}
>   	job->performance_query.count = copy.count;
>   	job->performance_query.nperfmons = copy.nperfmons;
>   	job->performance_query.ncounters = copy.ncounters;
> @@ -807,10 +791,6 @@ v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv,
>   	job->copy.stride = copy.stride;
>   
>   	return 0;
> -
> -error:
> -	__v3d_performance_query_info_free(qinfo, i);
> -	return err;
>   }
>   
>   /* Whenever userspace sets ioctl extensions, v3d_get_extensions parses data