[PATCH v5 1/2] drm/loongson: Introduce component framework support

Sui Jingfeng sui.jingfeng at linux.dev
Tue Jul 30 17:46:36 UTC 2024


Hi,


On 2024/7/29 14:40, Markus Elfring wrote:
>>> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
>> @@ -0,0 +1,108 @@
>>> +#ifndef __LOONGSON_DRV_H__
>> +#define __LOONGSON_DRV_H__
>>
> I suggest to omit leading underscores from such identifiers.
> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier


I suggest add this rules to the checkpatch.pl script,

It's more safe to follow *after* your suggestion is accepted.

After all, the checkpatch.pl is de-facto standard.

checkpatch.pl is happy about my patch for now.


> Regards,
> Markus

-- 
Best regards,
Sui



More information about the dri-devel mailing list