[PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

[Chris Healy]

On Mon, Jun 3, 2024 at 3:12 AM Dmitry Baryshkov
<dmitry.baryshkov at linaro.org> wrote:
>
> On Sun, Jun 02, 2024 at 08:25:39PM -0700, Chris Healy wrote:
> > On an i.MX53 QSB with HDMI daughter board, this patch series is:
> >
> > Tested-by: Chris Healy <cphealy at gmail.com>
>
> Thank you! I assume this is imx53-qsrb-hdmi ?

Yes
>
> >
> > HDMI output still works correctly and the bridges file reflects the changes:
> >
> > Before:
> >
> > root:/sys/kernel/debug/dri/display-subsystem/encoder-0 cat bridges
> > bridge[0]: 0xc0fa76d8
> >         type: [0] Unknown
> >         ops: [0x0]
> > bridge[1]: 0xc0fba03c
> >         type: [0] Unknown
> >         OF: /soc/bus at 60000000/i2c at 63fc4000/bridge-hdmi at 39:sil,sii9022
> >         ops: [0x7] detect edid hpd
> >
> >
> > After:
> >
> > root:/sys/kernel/debug/dri/display-subsystem/encoder-0 cat bridges
> > bridge[0]: 0xc0fa76d8
> >         type: [0] Unknown
> >         ops: [0x0]
> > bridge[1]: 0xc0fb9f5c
> >         type: [0] Unknown
> >         OF: /soc/bus at 60000000/i2c at 63fc4000/bridge-hdmi at 39:sil,sii9022
> >         ops: [0x7] detect edid hpd
> > bridge[2]: 0xc0fb9794
> >         type: [11] HDMI-A
> >         OF: /connector-hdmi:hdmi-connector
> >         ops: [0x0]
> >
> > On Sun, Jun 2, 2024 at 5:04 AM Dmitry Baryshkov
> > <dmitry.baryshkov at linaro.org> wrote:
> > >
> > > The IPUv3 DRM i.MX driver contains several codepaths for different
> > > usescases: both LDB and paralllel-display drivers handle next-bridge,
> > > panel and the legacy display-timings DT node on their own.
> > >
> > > Drop unused ddc-i2c-bus and edid handling (none of the DT files merged
> > > upstream ever used these features), switch to panel-bridge driver,
> > > removing the need to handle drm_panel codepaths separately and finally
> > > switch to drm_bridge_connector, removing requirement for the downstream
> > > bridges to create drm_connector on their own.
> > >
> > > This has been tested on the iMX53 with the DPI panel attached to LDB via
> > > LVDS decoder, using all possible usecases (lvds-codec + panel, panel
> > > linked directly to LDB node and the display-timings node).
> > >
> > > To be able to test on the iMX53 QSRB with the HDMI cape apply [1], [2]
> > >
> > > [1] https://lore.kernel.org/all/20240514030718.533169-1-victor.liu@nxp.com/
> > > [2] https://lore.kernel.org/all/20240602-imx-sii902x-defconfig-v1-1-71a6c382b422@linaro.org/
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > > ---
> > > Changes in v3:
> > > - Notice (soft) dependencies in the cover letter (Chris)
> > > - Select DRM_BRIDGE instead of depending on it (Philipp)
> > > - Dropped unused selection of DRM_PANEL (Philipp)
> > > - Added missing include of <drm/bridge/imx.h> to parallel-display.c
> > >   (Philipp)
> > > - Link to v2: https://lore.kernel.org/r/20240331-drm-imx-cleanup-v2-0-d81c1d1c1026@linaro.org
> > >
> > > Changes in v2:
> > > - Fixed drm_bridge_attach flags in imx/parallel-display driver.
> > > - Moved the legacy bridge to drivers/gpu/drm/bridge
> > > - Added missing EXPORT_SYMBOL_GPL to the iMX legacy bridge
> > > - Link to v1: https://lore.kernel.org/r/20240311-drm-imx-cleanup-v1-0-e104f05caa51@linaro.org
> > >
> > > ---
> > > Dmitry Baryshkov (12):
> > >       dt-bindings: display: fsl-imx-drm: drop edid property support
> > >       dt-bindings: display: imx/ldb: drop ddc-i2c-bus property
> > >       drm/imx: cleanup the imx-drm header
> > >       drm/imx: parallel-display: drop edid override support
> > >       drm/imx: ldb: drop custom EDID support
> > >       drm/imx: ldb: drop custom DDC bus support
> > >       drm/imx: ldb: switch to drm_panel_bridge
> > >       drm/imx: parallel-display: switch to drm_panel_bridge
> > >       drm/imx: add internal bridge handling display-timings DT node
> > >       drm/imx: ldb: switch to imx_legacy_bridge / drm_bridge_connector
> > >       drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector
> > >       drm/imx: move imx_drm_connector_destroy to imx-tve
> > >
> > >  .../bindings/display/imx/fsl-imx-drm.txt           |   2 -
> > >  .../devicetree/bindings/display/imx/ldb.txt        |   1 -
> > >  drivers/gpu/drm/bridge/imx/Kconfig                 |  10 +
> > >  drivers/gpu/drm/bridge/imx/Makefile                |   1 +
> > >  drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c     |  85 +++++++++
> > >  drivers/gpu/drm/imx/ipuv3/Kconfig                  |  10 +-
> > >  drivers/gpu/drm/imx/ipuv3/imx-drm-core.c           |   7 -
> > >  drivers/gpu/drm/imx/ipuv3/imx-drm.h                |  14 --
> > >  drivers/gpu/drm/imx/ipuv3/imx-ldb.c                | 203 +++++----------------
> > >  drivers/gpu/drm/imx/ipuv3/imx-tve.c                |   8 +-
> > >  drivers/gpu/drm/imx/ipuv3/parallel-display.c       | 139 +++-----------
> > >  include/drm/bridge/imx.h                           |  13 ++
> > >  12 files changed, 187 insertions(+), 306 deletions(-)
> > > ---
> > > base-commit: 850ca533e572247b6f71dafcbf7feb0359350963
> > > change-id: 20240310-drm-imx-cleanup-10746a9b71f5
> > >
> > > Best regards,
> > > --
> > > Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > >
>
> --
> With best wishes
> Dmitry