[PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

[Abhinav Kumar]

On 4/22/2024 4:06 AM, Dmitry Baryshkov wrote:
> On Fri, Apr 19, 2024 at 07:32:35PM -0700, Abhinav Kumar wrote:
>>
>>
>> On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote:
>>> On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote:
>>>>
>>>>
>>>> On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote:
>>>>> The msm_kms_funcs::check_modified_format() callback is not used by the
>>>>> driver. Drop it completely.
>>>>>
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>>> ---
>>>>>     drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 45 -----------------------------
>>>>>     drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 15 ----------
>>>>>     drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c     |  1 -
>>>>>     drivers/gpu/drm/msm/msm_kms.h               |  5 ----
>>>>>     4 files changed, 66 deletions(-)
>>>>>
>>>>
>>>> I think in this case, I am leaning towards completing the implementation
>>>> rather than dropping it as usual.
>>>>
>>>> It seems its easier to just add the support to call this like the attached
>>>> patch?
>>>
>>> Please don't attach patches to the email. It makes it impossible to
>>> respond to them.
>>>
>>
>> I attached it because it was too much to paste over here.
>>
>> Please review msm_framebuffer_init() in the downstream sources.
>>
>> The only missing piece I can see is the handling of DRM_MODE_FB_MODIFIERS
>> flags.
> 
> I checked and I don't like this approach.
> 
> With the generic formats database in place, there should be no
> driver-specific code that handles formats. Moreover, I think this should
> be handled by the generic code in framebuffer_check() if msm driver
> implements a proper get_format_info() callback. Please consider sending
> a patch that does it. For now I can only consider the function in
> question to be a dead code which should be dropped.
> 

Alright, lets revisit this implementation later on and for this series 
we can go with dropping dpu_format_check_modified_format().