[PATCH] drm/edid: reduce DisplayID log spamming

[Thomas Zimmermann]

Am 06.06.24 um 14:35 schrieb Jani Nikula:
> Debug printing at DisplayID validation leads to lots of log spamming as
> it's called at DisplayID iterators during EDID parsing. Remove it, and
> replace with a less noisy message at connector EDID update.
>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/gpu/drm/drm_displayid.c | 3 ---
>   drivers/gpu/drm/drm_edid.c      | 5 +++++
>   2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_displayid.c b/drivers/gpu/drm/drm_displayid.c
> index 9d01d762801f..b4fd43783c50 100644
> --- a/drivers/gpu/drm/drm_displayid.c
> +++ b/drivers/gpu/drm/drm_displayid.c
> @@ -33,9 +33,6 @@ validate_displayid(const u8 *displayid, int length, int idx)
>   	if (IS_ERR(base))
>   		return base;
>   
> -	DRM_DEBUG_KMS("base revision 0x%x, length %d, %d %d\n",
> -		      base->rev, base->bytes, base->prod_id, base->ext_count);
> -
>   	/* +1 for DispID checksum */
>   	dispid_length = sizeof(*base) + base->bytes + 1;
>   	if (dispid_length > length - idx)
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index f68a41eeb1fa..9fc7292f5382 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -6629,6 +6629,11 @@ static void update_displayid_info(struct drm_connector *connector,
>   
>   	displayid_iter_edid_begin(drm_edid, &iter);
>   	displayid_iter_for_each(block, &iter) {
> +		drm_dbg_kms(connector->dev,
> +			    "[CONNECTOR:%d:%s] DisplayID extension version 0x%02x, primary use 0x%02x\n",
> +			    connector->base.id, connector->name,
> +			    displayid_version(&iter),
> +			    displayid_primary_use(&iter));
>   		if (displayid_version(&iter) == DISPLAY_ID_STRUCTURE_VER_20 &&
>   		    (displayid_primary_use(&iter) == PRIMARY_USE_HEAD_MOUNTED_VR ||
>   		     displayid_primary_use(&iter) == PRIMARY_USE_HEAD_MOUNTED_AR))

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)